-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AppSource Gallery follow-up fixes #586
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te/brobledodiaz/appsource-gallery-fixes
…//github.com/microsoft/BCApps into private/brobledodiaz/appsource-gallery-fixes
…//github.com/microsoft/BCApps into private/brobledodiaz/appsource-gallery-fixes
…//github.com/microsoft/BCApps into private/brobledodiaz/appsource-gallery-fixes
…//github.com/microsoft/BCApps into private/brobledodiaz/appsource-gallery-fixes
SBalslev
previously approved these changes
Feb 15, 2024
darjoo
previously approved these changes
Feb 16, 2024
grobyns
reviewed
Feb 16, 2024
src/System Application/App/AppSource Gallery/src/AppSourceProductManager.Codeunit.al
Outdated
Show resolved
Hide resolved
grobyns
reviewed
Feb 16, 2024
src/System Application/App/AppSource Gallery/src/AppSourceProductManager.Codeunit.al
Outdated
Show resolved
Hide resolved
grobyns
reviewed
Feb 16, 2024
src/System Application/App/AppSource Gallery/src/AppSourceProductManager.Codeunit.al
Show resolved
Hide resolved
grobyns
reviewed
Feb 16, 2024
src/System Application/App/AppSource Gallery/src/AppSourceProductManager.Codeunit.al
Outdated
Show resolved
Hide resolved
…//github.com/microsoft/BCApps into private/brobledodiaz/appsource-gallery-fixes
…//github.com/microsoft/BCApps into private/brobledodiaz/appsource-gallery-fixes
WaelAbuSeada
approved these changes
Feb 20, 2024
...ystem Application/App/AppSource Gallery/src/AppSourceProductManagerDependencies.Interface.al
Outdated
Show resolved
Hide resolved
SBalslev
approved these changes
Feb 21, 2024
grobyns
approved these changes
Feb 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still waiting on the PR that adds the test library app
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
AppSource Marketplace Iframe is being deprecated, so we are creating our own solution to replace it. This is a follow-up PR that fixes a few bugs.
Work Item(s)
Fixes AB#467161